Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update COW balance button #377

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Update COW balance button #377

merged 3 commits into from
Apr 6, 2022

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Apr 5, 2022 •
edited
Loading

Summary

Second part of the #349

  • renamed CowClaimButton to CowBalanceButton
  • removed glow effect from cow balance button
  • updated button link to /profile
  • updated balance button to show vCow + Cow balance

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@nenadV91 nenadV91 marked this pull request as ready for review April 5, 2022 16:47
@nenadV91 nenadV91 requested review from a team April 5, 2022 16:49
@fairlighteth
Copy link
Contributor

Looks good!

One thing we might consider, is to remove the (v)COW appended text:

Now:
Screen Shot 2022-04-05 at 18 47 16

Suggestion:
Screen Shot 2022-04-05 at 18 47 32

0 balance suggestion:
Screen Shot 2022-04-05 at 18 47 53

Why? Keeps the header more minimalistic and reduces noise.

fairlighteth
fairlighteth approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@fairlighteth fairlighteth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Please take my suggestion in consideration.

@nenadV91 nenadV91 merged commit cb1af37 into release/1.13 Apr 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
@elena-zh
Copy link

elena-zh commented Apr 6, 2022

Changes LGTM besides a low-priority issue #382

@nenadV91 nenadV91 deleted the 2639/hide-claiming-page-2 branch June 14, 2022 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fairlighteth fairlighteth fairlighteth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nenadV91 @fairlighteth @elena-zh